-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing dtype issues in network.get #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GianlucaFicarelli : Can you take a quick look and provide your opinion to the questions I raised.
No need to do a full review or spend too much time on this. Just initial thoughts is fine.
Also: I couldn't come up with new scenarios we should be testing for. If anything comes to mind, let me know.
0b33314
to
a31aee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
4fb38f0
to
5a77746
Compare
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 2186 2168 -18
=========================================
- Hits 2186 2168 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
5a77746
to
5c839af
Compare
Fixes #198 .
Fixes #203 .
Furthermore the following can be closed: